Move spotlight dismissal/re-show logic to server side #11171
+88
−131
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Test the buildOption 1. Jetpack Beta
Option 2. Jurassic Ninja - available for logged-in A12s🚀 Launch a JN site with this branch 🚀 ℹ️ Install this Tampermonkey script to get more options. Build info:
Note: the build is updated when a new commit is pushed to this PR. |
This removes client-side dismiss/wait/re-show logic in preparation for the WooPayments server handling this functionality. Changes: - Remove filter_variations_by_dismissals() method from promotions service - Simplify mock data to return a single spotlight variation - Remove PromotionTypeConfig and PromotionConfig from client types - Update tests to verify cache clearing and context hash invalidation The client now simply: 1. Sends dismissal timestamps to server via store_context 2. Displays whatever variation the server returns 3. Clears cache on dismissal to trigger fresh server request Fixes WOOPMNT-5531 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <[email protected]>
dmallory42
force-pushed
the
woopmnt-5531-move-spotlight-dismissal-logic-to-server
branch
from
ff310d0 to
0d4f1c7
Compare
Contributor
|
Size Change: 0 B Total Size: 907 kB ℹ️ View Unchanged
|
mordeth
approved these changes
Dec 2, 2025
Contributor
mordeth
left a comment
mordeth
left a comment
There was a problem hiding this comment.
✅ Code changes are looking good!
✅ The spotlight is displayed correctly with the mocked data.
Contributor
|
@dmallory42, could hold off on this PR as it will definitely conflict with my work (it includes it)? |
Contributor
Author
|
Thanks for the review, @mordeth - holding off for now while @vladolaru works on the updates to the data shape. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes WOOPMNT-5531
Changes proposed in this Pull Request
This PR moves the spotlight dismissal/re-show logic from the client to the server side, simplifying the client implementation.
Why is this change needed?
Per the p1764238694991919-slack-C09RCGJFMK7, the dismiss and wait/re-show logic should not be handled on the client. Instead, the client should send dismissal timestamps when requesting promotions, and the server should determine which variation (if any) to return.
What does this change do?
filter_variations_by_dismissals()method fromWC_Payments_PM_Promotions_ServicePromotionTypeConfigandPromotionConfigtypes from clientHow it works now:
store_contextThe client no longer has any dismiss/wait/re-show logic - it just displays whatever the server returns.
How can this code break?
store_contextwhen it's implementedWhat are we doing to make sure this code doesn't break?
Testing instructions
npm run changelogto add a changelog file, choosepatchto leave it empty if the change is not significant. You can add multiple changelog files in one PR by running this command a few times.Post merge